Retrieve relevant memories instead of dumping the full store - #17
Draft
ingoau wants to merge 1 commit into
Draft
Conversation
Stop injecting every memory into each reply. Cache the JSON store in memory, rank records by Slack ID and keywords, and expose search/delete so the prompt stays bounded as memory grows. Co-authored-by: Ingo Wolf <me@ingo.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The memory system was becoming expensive for a simple reason: every reply dumped the entire
memory.jsoninto the system prompt, and everylist()re-read the file from disk. Combined with “err toward remembering,” token cost grew unbounded.This change keeps the same on-disk JSON format and makes retrieval selective:
MEMORY_CONTEXT_LIMIT(default 24). Prompt records are{ id, content }only.search_memory/delete_memory— look up omitted facts on demand, and prune obsolete or duplicate records.Kevin is told when records were omitted so He can search instead of guessing.